Issue 12304016: Restructure SplayTreeMap to be reusable (e.g., for a SplayTreeSet).

Issue 12304016: Restructure SplayTreeMap to be reusable (e.g., for a SplayTreeSet). (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Restructure SplayTreeMap to be reusable (e.g., for a SplayTreeSet). Add documentation that all keys of the map must be comparable to each other. Committed: https://code.google.com/p/dart/source/detail?r=19209

Patch Set 1 #

Patch Set 2 : Add SplayTreeSet. #

Patch Set 3 : Remove Set for now. Make taking a comparator the default. #

Patch Set 4 : Better doc #

Total comments: 2

Patch Set 5 : Address comments. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+576 lines, -521 lines)			Patch
M	sdk/lib/collection/splay_tree.dart	View	1 2 3 4	24 chunks	+170 lines, -133 lines	0 comments	Download
M	tests/corelib/map_test.dart	View	1 2	1 chunk	+243 lines, -227 lines	0 comments	Download
M	tests/corelib/set_test.dart	View	1 2 3 4	1 chunk	+163 lines, -161 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Adding the SplayTreeSet makes the code not work on the VM. We can either wait ...

7 years, 10 months ago (2013-02-19 13:56:34 UTC) #1

floitsch

LGTM. https://codereview.chromium.org/12304016/diff/7003/sdk/lib/collection/splay_tree.dart File sdk/lib/collection/splay_tree.dart (right): https://codereview.chromium.org/12304016/diff/7003/sdk/lib/collection/splay_tree.dart#newcode34 sdk/lib/collection/splay_tree.dart:34: * It performs basic operations move part of ...

7 years, 9 months ago (2013-02-27 16:31:11 UTC) #3

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-02-28 10:02:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r19209 (presubmit successful).

Expand Messages | Collapse Messages