Issue 12304009: Trust declared type of the receiver to compute its initial compile type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12304009: Trust declared type of the receiver to compute its initial compile type. (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 10 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Trust declared type of the receiver to compute its initial compile type. Fix a bug in the ToNullableCid which was leaving cid_ uninitialized when class has subclasses. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18641

Patch Set 1 #

Total comments: 2

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -8 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	2 chunks	+21 lines, -4 lines	2 comments	Download
M	runtime/vm/intermediate_language.h	View	3 chunks	+9 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/12304009/diff/1/runtime/vm/flow_graph_type_propagator.cc File runtime/vm/flow_graph_type_propagator.cc (right): https://codereview.chromium.org/12304009/diff/1/runtime/vm/flow_graph_type_propagator.cc#newcode463 runtime/vm/flow_graph_type_propagator.cc:463: // for example reciever and construction phase. s/reciever/receiver/

7 years, 10 months ago (2013-02-18 15:44:39 UTC) #2

srdjan

7 years, 10 months ago (2013-02-19 16:41:59 UTC) #3

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/12304009/diff/1/runtime/vm/flow_graph_type_pr...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/12304009/diff/1/runtime/vm/flow_graph_type_pr...
runtime/vm/flow_graph_type_propagator.cc:463: // for example reciever and
construction phase.
How does this work: you can trust the receiver type only if has not been
subclassed.  Please elaborate in comment.

Expand Messages | Collapse Messages