Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1230273002: Analyzer code cleanup. (Closed)

Created:
5 years, 5 months ago by pquitslund
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Analyzer code cleanup. Removed some unused imports and fixed member sorting. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/a81c30828394c9620459643d3558980bcb6525a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -87 lines) Patch
M pkg/analyzer/lib/source/sdk_ext.dart View 5 chunks +61 lines, -64 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/source/sdk_ext_test.dart View 2 chunks +20 lines, -21 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 5 months ago (2015-07-10 20:39:00 UTC) #2
scheglov
LGTM
5 years, 5 months ago (2015-07-10 20:41:12 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as a81c30828394c9620459643d3558980bcb6525a5 (presubmit successful).
5 years, 5 months ago (2015-07-10 20:42:32 UTC) #4
Brian Wilkerson
5 years, 5 months ago (2015-07-10 20:45:43 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698