Issue 12301032: Use the correct set of reserved identifiers in pub validations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12301032: Use the correct set of reserved identifiers in pub validations. (Closed)

Created:
7 years, 10 months ago by nweiz

Modified:
7 years, 10 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the correct set of reserved identifiers in pub validations. We had been using the set listed in the spec as "BUILT_IN_IDENTIFIER", but apparently those are the built-in identifiers that are valid for user use. Now we're using the set listed in the spec as "reserved words". BUG=8628 Committed: https://code.google.com/p/dart/source/detail?r=18716

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	utils/pub/validator/name.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	utils/tests/pub/validator_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

7 years, 10 months ago (2013-02-19 19:55:51 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18716 (presubmit successful).

Expand Messages | Collapse Messages