dart2js: Add boilerplate strings for the startup-emitter.

dart2js: Add boilerplate strings for the startup-emitter.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/79645ebd9de14ab7c5c1f6192c5dad4df6814042

[floitsch, 2015-07-09 16:34:50]

floitsch@google.com changed reviewers:
+ herhut@google.com

[floitsch, 2015-07-09 16:34:50]

ccing Siggi, since this is the real meat of the startup-emitter.

[Siggi Cherem (dart-lang), 2015-07-09 23:54:06]

sigmund@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-07-09 23:54:07]

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:72: // the
first access, it is initialize with the [initializer].
nit: it is initialize => it is initialized

[floitsch, 2015-07-10 17:13:59]

PTAL.
I have removed the tear-off code for now. There is a separate CL for tear-offs
anyway, and it should be reviewed in that context.

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:72: // the
first access, it is initialize with the [initializer].
On 2015/07/09 23:54:07, Siggi Cherem (dart-lang) wrote:
> nit: it is initialize => it is initialized

Done.

[Siggi Cherem (dart-lang), 2015-07-10 17:24:36]

lgtm, but I'd wait for Stephan's reply as he is more familiar with the rest of
the changes

[Siggi Cherem (dart-lang), 2015-07-14 15:57:25]

(it seems this was next in the list of changes. feel free to submit, I believe
Stephan is on vacation for a bit so I can continue reviewing the changes until
he gets back)

https://codereview.chromium.org/1229913003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229913003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:35: const
String mainBoilerplate = '''
minor nit question: Since you have other changes stacked after this, it might
reduce conflicts if you keep it as is for now, but just wanted to get your
thoughts on moving this down after FragmentEmitter. Not sure what has been your
convention so far, I tend to try to keep the element whose name matches the
filename upfront, so it is clear what this file is all about.

[floitsch, 2015-07-17 17:59:32]

https://codereview.chromium.org/1229913003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229913003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:35: const
String mainBoilerplate = '''
On 2015/07/14 15:57:25, Siggi Cherem (dart-lang) wrote:
> minor nit question: Since you have other changes stacked after this, it might
> reduce conflicts if you keep it as is for now, but just wanted to get your
> thoughts on moving this down after FragmentEmitter. Not sure what has been
your
> convention so far, I tend to try to keep the element whose name matches the
> filename upfront, so it is clear what this file is all about.

I found this to be the most important part of the emitter, but I'm happy to move
it down. As you say: this would provide lots of merge-conflicts, so I prefer
doing this in a follow-up CL.

[floitsch, 2015-07-17 18:00:07]

Committed patchset #3 (id:40001) manually as
79645ebd9de14ab7c5c1f6192c5dad4df6814042 (presubmit successful).

[herhut, 2015-07-27 11:02:22]

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:34: //
names we want. Furthermore, the minifier reduces the names of the variables.
To be uber precise here, it is the pretty printer in the js ast package that
does variable minification. Unfortunately, that is independent of the namer, so
renamed variables can clash with globals unless they are in a holder. I am not
even sure whether variable names might not shadow the holders themselves.

[floitsch, 2015-07-29 15:26:24]

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1229913003/diff/1/pkg/compiler/lib/src/js_emi...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:34: //
names we want. Furthermore, the minifier reduces the names of the variables.
On 2015/07/27 11:02:22, herhut wrote:
> To be uber precise here, it is the pretty printer in the js ast package that
> does variable minification. Unfortunately, that is independent of the namer,
so
> renamed variables can clash with globals unless they are in a holder. I am not
> even sure whether variable names might not shadow the holders themselves. 

Updated the comment (new CL coming).
Since the holders are locals too, the pretty-printer won't shadow them.