Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1229913002: dart2js: add FragmentEmitter for startup-emitter. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add comment. #

Patch Set 3 : Merge #

Patch Set 4 : Merge #

Total comments: 2

Patch Set 5 : Fix part-of name. #

Patch Set 6 : Reupload #

Total comments: 2

Patch Set 7 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -2 lines) Patch
A pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 2 3 4 5 6 2 chunks +52 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
floitsch
Forgot to send this CL. Should be reviewed before "Add boilerplate strings for the startup-emitter".
5 years, 5 months ago (2015-07-10 11:43:25 UTC) #2
Siggi Cherem (dart-lang)
lgtm (minor thing below) https://codereview.chromium.org/1229913002/diff/100001/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart (right): https://codereview.chromium.org/1229913002/diff/100001/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart#newcode177 pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:177: return '// Generated by dart2js ...
5 years, 5 months ago (2015-07-14 01:19:11 UTC) #4
floitsch
https://codereview.chromium.org/1229913002/diff/100001/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart (right): https://codereview.chromium.org/1229913002/diff/100001/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart#newcode177 pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:177: return '// Generated by dart2js (CSP), ' On 2015/07/14 ...
5 years, 5 months ago (2015-07-14 09:21:16 UTC) #5
floitsch
Committed patchset #7 (id:120001) manually as 9c2195e814196712281d5dd11589202e1a3b3487 (presubmit successful).
5 years, 5 months ago (2015-07-14 09:23:56 UTC) #6
herhut
Late comment due to vacation... https://codereview.chromium.org/1229913002/diff/60001/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart (right): https://codereview.chromium.org/1229913002/diff/60001/pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart#newcode129 pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:129: List<Fragment> fragments = program.fragments; ...
5 years, 4 months ago (2015-07-27 11:03:15 UTC) #7
floitsch
5 years, 4 months ago (2015-07-29 16:47:34 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/1229913002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart (right):

https://codereview.chromium.org/1229913002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart:129:
List<Fragment> fragments = program.fragments;
On 2015/07/27 11:03:15, herhut wrote:
> Should we add a getter for deferredFragments? I don't like the skip(1) all
over
> the place.

There is already one. I just need to use it...

Powered by Google App Engine
This is Rietveld 408576698