Start tracking all registered elements in one big full function set

Start tracking all registered elements in one big full function set
and use that to simplify some of the queries on the world.

I found a few places where we seem to be mistreating getters with
side-effects in the builder. Please review carefully.

R=ngeoffray@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=18622

[ngeoffray, 2013-02-18 08:35:33]

LGTM!

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2236: if
(selector is TypedSelector) {
Maybe we can put all of this logic in the selector class.

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3952: new
HInvokeDynamicGetter(selector, null, receiver, !hasGetter);
change the constructor to have a named argument? This is an easy mistake to
reproduce.

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3968: bool hasGetter
= compiler.world.hasAnyUserDefinedGetter(selector);
You can remove this hasGetter.

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/world.dart (left):

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:15: final FunctionSet
userDefinedSetters;
So special handling user-defined getters/setters turned out to not optimize
anything?

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/world.dart (right):

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:141: return (result != null
&& result.isField())
Fits in one line?

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:155: return
(receiverTypeElement.isSubclassOf(enclosing))
Is this to prevent from subtypes? If selector is not a subtype kind but an exact
or subclass, you would not have to check, right?

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:168: return allFunctions
Move this to the FullFunctionSet? Looks like without caching this will be
expensive. Unless you think we won't see much programs with a big number of no
such methods.

[kasperl, 2013-02-18 09:47:07]

PTAL.

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/world.dart (right):

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:141: return (result != null
&& result.isField())
On 2013/02/18 08:35:34, ngeoffray wrote:
> Fits in one line?

Done.

https://codereview.chromium.org/12299006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/world.dart:155: return
(receiverTypeElement.isSubclassOf(enclosing))
On 2013/02/18 08:35:34, ngeoffray wrote:
> Is this to prevent from subtypes? If selector is not a subtype kind but an
exact
> or subclass, you would not have to check, right?

Added a comment to explain what's going on.

[ngeoffray, 2013-02-18 10:11:40]

Still LGTM