Issue 1229893002: dart2js cps: Redundant join elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1229893002: dart2js cps: Redundant join elimination. (Closed)

Created:
5 years, 5 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Redundant join elimination. There is a new pass that optimizes for continuations that branch on a parameter, where every invocation passes a constant as that parameter. This avoids unnecessary boolean flags that can arise from specializing a call to a method that returns a boolean. A current short-coming is that this lives in its own pass. I believe shrinking reductions and redundant joins elimination can trigger redexes of each other, so in theory we may still get redundant joins in the output. The two passes might need to be reorganized at some point. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/306b627a05a6e89a4bceb2d96ef376fceb081743

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+307 lines, -15 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/optimizers.dart	View	2 chunks	+14 lines, -0 lines	0 comments	Download
A	pkg/compiler/lib/src/cps_ir/redundant_join.dart	View	1 chunk	+276 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View	2 chunks	+2 lines, -11 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/task.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 5 months ago (2015-07-10 14:32:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
306b627a05a6e89a4bceb2d96ef376fceb081743 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages