Issue 12298029: Turn error into warning for non-static member access through the class.

Issue 12298029: Turn error into warning for non-static member access through the class. (Closed)

Created:
7 years, 10 months ago by kasperl

Modified:
7 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Turn error into warning for non-static member access through the class. Make sure 'abstract fields' are treated as instance members so they get mixed in when applying mixins. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18661

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix co19 status. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -22 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		2 chunks	+5 lines, -7 lines	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	4 chunks	+0 lines, -6 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
A	tests/language/mixin_getter_regression_test.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/12298029/diff/1/tests/language/mixin_getter_regression_test.dart File tests/language/mixin_getter_regression_test.dart (right): https://codereview.chromium.org/12298029/diff/1/tests/language/mixin_getter_regression_test.dart#newcode6 tests/language/mixin_getter_regression_test.dart:6: // properly mixed in. How is this test ...

7 years, 10 months ago (2013-02-19 09:18:49 UTC) #2

kasperl

7 years, 10 months ago (2013-02-19 09:20:59 UTC) #3

https://codereview.chromium.org/12298029/diff/1/tests/language/mixin_getter_r...
File tests/language/mixin_getter_regression_test.dart (right):

https://codereview.chromium.org/12298029/diff/1/tests/language/mixin_getter_r...
tests/language/mixin_getter_regression_test.dart:6: // properly mixed in.
On 2013/02/19 09:18:49, Johnni Winther wrote:
> How is this test related to the changes?

Before this change abstract fields (like the getter y) weren't mixed in because
they weren't instance members, so the class D wouldn't have the y getter. Fail.

Expand Messages | Collapse Messages