Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 12298027: Revert "Make Comparable generic." (Closed)

Created:
7 years, 10 months ago by kasperl
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Make Comparable generic." This reverts commit dd714db881a0ad63eaa1e5491e93dd8843eb5929. R=lrn@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M pkg/fixnum/lib/src/int32.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/logging/lib/logging.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/serialization/lib/src/basic_rule.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/comparable.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/core/date_time.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/num.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/css/source.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/package.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M utils/template/source.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
7 years, 10 months ago (2013-02-19 08:05:47 UTC) #1
kasperl
TBR'ed.
7 years, 10 months ago (2013-02-19 08:06:13 UTC) #2
Lasse Reichstein Nielsen
7 years, 10 months ago (2013-02-20 09:32:31 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698