Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1229563006: Second attempt at fixing SdkExtUriResolver.restoreAbsolute (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Second attempt at fixing SdkExtUriResolver.restoreAbsolute BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/13deb397a0a9eb4e5568486d68f2bd6cfe9bd1fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M pkg/analyzer/lib/source/sdk_ext.dart View 4 chunks +30 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 5 months ago (2015-07-08 19:26:09 UTC) #2
Cutch
5 years, 5 months ago (2015-07-08 19:27:12 UTC) #3
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-08 19:49:23 UTC) #4
Cutch
5 years, 5 months ago (2015-07-08 19:50:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13deb397a0a9eb4e5568486d68f2bd6cfe9bd1fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698