Issue 12295039: Fixing CssStyleDeclaration to not throw exceptions for unsupported values.

Issue 12295039: Fixing CssStyleDeclaration to not throw exceptions for unsupported values. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing CssStyleDeclaration to not throw exceptions for unsupported values. Only occurs on IE9, but unsupported values should fail silently. BUG=8588 Committed: https://code.google.com/p/dart/source/detail?r=19024

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -10 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	tests/html/cssstyledeclaration_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate	View	1 chunk	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://codereview.chromium.org/12295039/diff/1/tests/html/element_classes_test.dart File tests/html/element_classes_test.dart (right): https://codereview.chromium.org/12295039/diff/1/tests/html/element_classes_test.dart#newcode170 tests/html/element_classes_test.dart:170: should there be something in this test?

7 years, 10 months ago (2013-02-20 17:15:07 UTC) #2

blois

7 years, 10 months ago (2013-02-20 20:51:12 UTC) #3

blois

7 years, 10 months ago (2013-02-26 00:48:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19024 (presubmit successful).

Expand Messages | Collapse Messages