Issue 12295017: Use compile type to improve stores to Int32List and Uint32List on ia32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12295017: Use compile type to improve stores to Int32List and Uint32List on ia32. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use compile type to improve stores to Int32List and Uint32List on ia32. If the value stored is a smi, we just untag and store it. There is no need to unbox it into an XMM register first. Committed: https://code.google.com/p/dart/source/detail?r=18647

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	runtime/vm/intermediate_language.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	runtime/vm/intermediate_language_ia32.cc	View	1	3 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/12295017/diff/1/runtime/vm/intermediate_language_ia32.cc File runtime/vm/intermediate_language_ia32.cc (right): https://codereview.chromium.org/12295017/diff/1/runtime/vm/intermediate_language_ia32.cc#newcode1492 runtime/vm/intermediate_language_ia32.cc:1492: if (RequiredInputRepresentation(2) == kTagged) { I suggest you ...

7 years, 10 months ago (2013-02-18 16:21:44 UTC) #2

Florian Schneider

7 years, 10 months ago (2013-02-18 16:33:31 UTC) #3

https://codereview.chromium.org/12295017/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/12295017/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language_ia32.cc:1492: if
(RequiredInputRepresentation(2) == kTagged) {
On 2013/02/18 16:21:44, Vyacheslav Egorov (Google) wrote:
> I suggest you encapsulate this check (and two above) in a function called
> IsSmiValue() or similar. 

Done.

Expand Messages | Collapse Messages