Support relative paths in path dependencies.

Support relative paths in path dependencies.

BUG=http://code.google.com/p/dart/issues/detail?id=8527

Review URL: https://codereview.chromium.org//12285010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18605 260f80e4-7a28-3924-810f-c04153c831b5

Committed: https://code.google.com/p/dart/source/detail?r=18715

[Bob Nystrom, 2013-02-19 19:19:00]

This reapplies the original patch from last week with a couple of tweaks to get
it working on Windows. The changes in this patch are:

- createSymlink() in io.dart handles Windows in the if (relative) body.
- relative_symlink_test.dart is a no-op on Windows.

Everything else is the same from the first patch.

[nweiz, 2013-02-19 19:30:51]

A few comments, but otherwise LGTM.

https://codereview.chromium.org/12294039/diff/1/utils/pub/git_source.dart
File utils/pub/git_source.dart (right):

https://codereview.chromium.org/12294039/diff/1/utils/pub/git_source.dart#new...
utils/pub/git_source.dart:76: // A single string is assumed to be a Git URL.
This should probably not be between two TODOs.

https://codereview.chromium.org/12294039/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12294039/diff/1/utils/pub/io.dart#newcode315
utils/pub/io.dart:315: Future<String> createPackageSymlink(String name, String
symlink, String target,
Un-switch the order of "symlink" and "target"

https://codereview.chromium.org/12294039/diff/1/utils/pub/pubspec.dart
File utils/pub/pubspec.dart (right):

https://codereview.chromium.org/12294039/diff/1/utils/pub/pubspec.dart#newcode77
utils/pub/pubspec.dart:77: factory Pubspec.parse(String filePath, String
contents,
It would be nice to separate out Pubspec.parse and Pubspec.load, like we do for
LockFile.

[Bob Nystrom, 2013-02-19 19:49:34]

Thanks!

https://codereview.chromium.org/12294039/diff/1/utils/pub/git_source.dart
File utils/pub/git_source.dart (right):

https://codereview.chromium.org/12294039/diff/1/utils/pub/git_source.dart#new...
utils/pub/git_source.dart:76: // A single string is assumed to be a Git URL.
On 2013/02/19 19:30:51, nweiz wrote:
> This should probably not be between two TODOs.

Done.

https://codereview.chromium.org/12294039/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12294039/diff/1/utils/pub/io.dart#newcode315
utils/pub/io.dart:315: Future<String> createPackageSymlink(String name, String
symlink, String target,
On 2013/02/19 19:30:51, nweiz wrote:
> Un-switch the order of "symlink" and "target"

Done.

https://codereview.chromium.org/12294039/diff/1/utils/pub/pubspec.dart
File utils/pub/pubspec.dart (right):

https://codereview.chromium.org/12294039/diff/1/utils/pub/pubspec.dart#newcode77
utils/pub/pubspec.dart:77: factory Pubspec.parse(String filePath, String
contents,
On 2013/02/19 19:30:51, nweiz wrote:
> It would be nice to separate out Pubspec.parse and Pubspec.load, like we do
for
> LockFile.

Good idea. Added a TODO.

[Bob Nystrom, 2013-02-19 19:50:36]

Committed patchset #2 manually as r18715 (presubmit successful).