Issue 1228943005: Avoid an uncaught error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1228943005: Avoid an uncaught error. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Avoid an uncaught error. Previously, we could try to send a message to the browser after the WebSocket connection had already closed because of a signal. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/77e119de7e15ad53b11b72646219e0125961a316

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -2 lines)			Patch
M	CHANGELOG.md	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/src/runner/browser/browser_manager.dart	View	2 chunks	+7 lines, -1 line	1 comment	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

lgtm https://codereview.chromium.org/1228943005/diff/1/lib/src/runner/browser/browser_manager.dart File lib/src/runner/browser/browser_manager.dart (right): https://codereview.chromium.org/1228943005/diff/1/lib/src/runner/browser/browser_manager.dart#newcode60 lib/src/runner/browser/browser_manager.dart:60: _channel.stream.listen(null, onDone: () => _closed = true); feels ...

5 years, 5 months ago (2015-07-14 23:33:38 UTC) #2

nweiz

5 years, 5 months ago (2015-07-15 01:39:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
77e119de7e15ad53b11b72646219e0125961a316 (presubmit successful).

Expand Messages | Collapse Messages