It's not allowed to have an initializer for a final field that is initialized where it's declared.

It's not allowed to have an initializer for a final field that is initialized where it's declared.
Committed: https://code.google.com/p/dart/source/detail?r=18672

[ahe, 2013-02-19 10:58:10]

LGTM except for the error message.

I like that you're using the element rather than the name.

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:959:
warning(initialized[field], MessageKind.ALREADY_INITIALIZED,
This is not optimal. See if you can use something similar to
reportErrorWithContext.

Ideally, you first report a message of kind "error", then a message of kind
"info".

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:963: Node
fieldNode = field.parseNode(visitor.compiler).asSendSet();
Why asSendSet?

[ngeoffray, 2013-02-19 11:18:10]

Thanks Peter, PTAL.

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:959:
warning(initialized[field], MessageKind.ALREADY_INITIALIZED,
On 2013/02/19 10:58:10, ahe wrote:
> This is not optimal. See if you can use something similar to
> reportErrorWithContext.
> 
> Ideally, you first report a message of kind "error", then a message of kind
> "info".

Done.

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:963: Node
fieldNode = field.parseNode(visitor.compiler).asSendSet();
On 2013/02/19 10:58:10, ahe wrote:
> Why asSendSet?

Because that's how we know the field is initialized. Is there another node?

[ahe, 2013-02-19 11:46:06]

LGTM!

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/12288041/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:963: Node
fieldNode = field.parseNode(visitor.compiler).asSendSet();
On 2013/02/19 11:18:10, ngeoffray wrote:
> On 2013/02/19 10:58:10, ahe wrote:
> > Why asSendSet?
> 
> Because that's how we know the field is initialized. Is there another node?

Sorry, I misread the code.