Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 12288040: Reapply "Make Comparable generic." (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Make Comparable generic." Avoid concurrent modification in dart2js. Avoid crash in VM by not using self-referential type bound. Committed: https://code.google.com/p/dart/source/detail?r=18667

Patch Set 1 #

Patch Set 2 : Fix problems. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M pkg/fixnum/lib/src/int32.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/logging/lib/logging.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/serialization/lib/src/basic_rule.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/splay_tree.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/comparable.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/core/date_time.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/num.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/string.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/css/source.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M utils/pub/package.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M utils/pub/version.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/template/source.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein Nielsen
TBR.
7 years, 10 months ago (2013-02-19 10:29:23 UTC) #1
floitsch
7 years, 10 months ago (2013-02-19 12:49:11 UTC) #2
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698