Fix a race condition in file watcher.

Fix a race condition in file watcher.

It was possible for events to be added to the events controller after it
had been closed if the call to close() came in while a method was
waiting on an asynchronous callback.

R=cbracken@google.com

Committed: https://github.com/dart-lang/watcher/commit/e7fa8d08336ccb4f65b59e6cd641f782aaa350c4

[nweiz, 2015-07-16 23:06:07]

nweiz@google.com changed reviewers:
+ cbracken@google.com

[Chris Bracken, 2015-07-16 23:23:38]

lgtm

[nweiz, 2015-07-16 23:25:01]

Committed patchset #1 (id:1) manually as
e7fa8d08336ccb4f65b59e6cd641f782aaa350c4 (presubmit successful).

[Bob Nystrom, 2015-07-17 15:58:22]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-07-17 15:58:22]

https://codereview.chromium.org/1228703007/diff/1/lib/src/file_watcher/pollin...
File lib/src/file_watcher/polling.dart (right):

https://codereview.chromium.org/1228703007/diff/1/lib/src/file_watcher/pollin...
lib/src/file_watcher/polling.dart:67: } finally {
Can you just add this to the outer try?

[nweiz, 2015-07-17 20:42:18]

https://codereview.chromium.org/1228703007/diff/1/lib/src/file_watcher/pollin...
File lib/src/file_watcher/polling.dart (right):

https://codereview.chromium.org/1228703007/diff/1/lib/src/file_watcher/pollin...
lib/src/file_watcher/polling.dart:67: } finally {
On 2015/07/17 15:58:22, Bob Nystrom wrote:
> Can you just add this to the outer try?

No, it needs to happen before "_eventsController.addError" in the catch block.

[Bob Nystrom, 2015-07-17 20:48:36]

lgtm