Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1228683003: Fix various pub issues. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix various pub issues. * Normalize paths before they're passed to dart2js. It handles "." and ".." path components poorly. * Ensure that paths emitted by list-package-dirs are always absolute and normalized for backwards-compatibility with the existing protocol. * Make Package.listFiles work for an in-memory package. * Fix an error message expectation in packages_file_test. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/072c5d85f4741bd4eede3eb8d309669b887e3c54

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -60 lines) Patch
M lib/src/barback/dart2js_transformer.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M lib/src/command/list_package_dirs.dart View 2 chunks +8 lines, -5 lines 0 comments Download
M lib/src/dart.dart View 6 chunks +47 lines, -43 lines 2 comments Download
M lib/src/log.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M lib/src/package.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/pubspec.dart View 1 chunk +4 lines, -1 line 0 comments Download
M test/packages_file_test.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 5 months ago (2015-07-09 22:28:19 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1228683003/diff/1/lib/src/dart.dart File lib/src/dart.dart (right): https://codereview.chromium.org/1228683003/diff/1/lib/src/dart.dart#newcode74 lib/src/dart.dart:74: // dart2js chokes on relative paths. Including "/./" ...
5 years, 5 months ago (2015-07-09 22:47:20 UTC) #2
nweiz
https://codereview.chromium.org/1228683003/diff/1/lib/src/dart.dart File lib/src/dart.dart (right): https://codereview.chromium.org/1228683003/diff/1/lib/src/dart.dart#newcode74 lib/src/dart.dart:74: // dart2js chokes on relative paths. Including "/./" can ...
5 years, 5 months ago (2015-07-09 23:42:44 UTC) #3
nweiz
5 years, 5 months ago (2015-07-09 23:42:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
072c5d85f4741bd4eede3eb8d309669b887e3c54 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698