Issue 1228643003: Fix SdkExtUriResolver.restoreAbsolute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1228643003: Fix SdkExtUriResolver.restoreAbsolute (Closed)

Created:
5 years, 5 months ago by Cutch

Modified:
5 years, 5 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix SdkExtUriResolver.restoreAbsolute BUG= Committed: https://github.com/dart-lang/sdk/commit/8e4a96d0162bdc273b9073817cfbbcb3bc779df0

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	pkg/analysis_server/lib/src/sdk_ext.dart	View	1	4 chunks	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

Committed patchset #2 (id:20001) manually as 8e4a96d0162bdc273b9073817cfbbcb3bc779df0 (presubmit successful).

5 years, 5 months ago (2015-07-08 17:00:26 UTC) #3

Brian Wilkerson

5 years, 5 months ago (2015-07-08 17:22:02 UTC) #6

Message was sent while issue was closed.

This solution won't work because there isn't a guarantee that SdkExtUriResolver
is the only place where a Source that needs to be handled will be created.

That said, given that DartUriResolver does not implement the restoreAbsolute
method, I'm wondering if I gave you bad advice and we should have *not*
implemented it in SdkExtUriResolver.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages