Unbreak pub:

Unbreak pub:

Revert "Make List.skip, List.take and List.reversed return Iterables, not Lists."

This reverts commit 44c3745a76acfad3d1d5bfc7a8b8c8e2def30e09.

Revert "Remove deprecated mappedBy."

This reverts commit 779ab69eab73e5e349245e99560b18955908e0cc.

BUG=dartbug.com/8560

Committed: https://code.google.com/p/dart/source/detail?r=18591

[Bob Nystrom, 2013-02-15 18:08:37]

It appears that r18750 completely broke pub. When the patch went in, 40 of pub's
~100 started failing.

As this bug shows, this is an actual breakage that affects users:
http://code.google.com/p/dart/issues/detail?id=8560

This reverts that patch. I also had to revert a later patch from Florian that
built on top of this one in order to get a clean revert.

I tested this using:

./tools/test.py -m release
./tools/test.py -m release -r d8 -c dartj2s
./tools/test.py -m release pub

And all tests pass (well, the dart2js tests are still running, but I'll update
this patch if there's an issue).

[Lasse Reichstein Nielsen, 2013-02-15 18:33:29]

LGTM. 
I'm still not sure what in that change makes it break, but I'll keep looking.

[Bob Nystrom, 2013-02-15 18:43:56]

On 2013/02/15 18:33:29, Lasse Reichstein Nielsen wrote:
> LGTM. 
> I'm still not sure what in that change makes it break, but I'll keep looking.

Thanks, I haven't investigated at all. I just took the quickest path to green
bots.

I'd like to get these patches reapplied and pub happy with them. It's very
likely a simple fix. Let me know if there's anything I can do to help. (Or, this
can wait until Monday if you'd like.)

If you want to test how a patch affects pub, just run:

./tools/test.py -m release pub

The tests should run pretty quickly.

[ricow1, 2013-02-16 13:04:15]

On 2013/02/15 18:43:56, Bob Nystrom wrote:
> On 2013/02/15 18:33:29, Lasse Reichstein Nielsen wrote:
> > LGTM. 
> > I'm still not sure what in that change makes it break, but I'll keep
looking.
> 
> Thanks, I haven't investigated at all. I just took the quickest path to green
> bots.
> 
> I'd like to get these patches reapplied and pub happy with them. It's very
> likely a simple fix. Let me know if there's anything I can do to help. (Or,
this
> can wait until Monday if you'd like.)
> 
> If you want to test how a patch affects pub, just run:
> 
> ./tools/test.py -m release pub
> 
> The tests should run pretty quickly.
LGTM, but could we please use svn revisions in cl descriptions - it is a manual
process to look up the changes using the reverted headlines - which is not easy.
It is pretty easy to get svn revisions from git svn

[Bob Nystrom, 2013-02-19 17:10:41]

On 2013/02/16 13:04:15, ricow1 wrote:
> On 2013/02/15 18:43:56, Bob Nystrom wrote:
> > On 2013/02/15 18:33:29, Lasse Reichstein Nielsen wrote:
> > > LGTM. 
> > > I'm still not sure what in that change makes it break, but I'll keep
> looking.
> > 
> > Thanks, I haven't investigated at all. I just took the quickest path to
green
> > bots.
> > 
> > I'd like to get these patches reapplied and pub happy with them. It's very
> > likely a simple fix. Let me know if there's anything I can do to help. (Or,
> this
> > can wait until Monday if you'd like.)
> > 
> > If you want to test how a patch affects pub, just run:
> > 
> > ./tools/test.py -m release pub
> > 
> > The tests should run pretty quickly.
> LGTM, but could we please use svn revisions in cl descriptions - it is a
manual
> process to look up the changes using the reverted headlines - which is not
easy.
> It is pretty easy to get svn revisions from git svn

Sorry, will do next time.