Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1228353010: Upgrade to the new test runner. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/string_scanner@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
D .status View 1 chunk +0 lines, -3 lines 0 comments Download
A .test_config View 1 chunk +3 lines, -0 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M test/error_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/line_scanner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/span_scanner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/string_scanner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-16 19:56:07 UTC) #1
Bob Nystrom
lgtm
5 years, 5 months ago (2015-07-16 20:02:48 UTC) #2
nweiz
5 years, 5 months ago (2015-07-16 20:43:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7f8bf873f1f59725c328984b9418c8cf7939890 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698