Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12282051: Prepare for removal of source_filter.gypi: (Closed)

Created:
7 years, 10 months ago by Ivan Posva
Modified:
7 years, 10 months ago
Reviewers:
podivilov1, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Prepare for removal of source_filter.gypi: - Guard OS-dependent source files with #if TARGET_OS_* in a similar fashion to the architecture dependent sources. Committed: https://code.google.com/p/dart/source/detail?r=18786

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+492 lines, -203 lines) Patch
M runtime/bin/crypto_android.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/bin/crypto_linux.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/bin/crypto_macos.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/bin/crypto_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/dbg_connection_android.cc View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M runtime/bin/dbg_connection_linux.cc View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M runtime/bin/dbg_connection_macos.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/dbg_connection_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
runtime/bin/directory_android.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/directory_linux.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/directory_macos.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/directory_win.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/bin/eventhandler_android.cc View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 2 2 chunks +12 lines, -7 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/eventhandler_win.cc View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M runtime/bin/extensions_android.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/extensions_linux.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/extensions_macos.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/extensions_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/file_android.cc View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/file_win.cc View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M runtime/bin/log_android.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/bin/log_linux.cc View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M runtime/bin/log_macos.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/log_win.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/bin/platform_android.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/bin/platform_macos.cc View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/process_android.cc View 1 2 2 chunks +14 lines, -9 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 2 2 chunks +14 lines, -9 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 2 2 chunks +13 lines, -8 lines 0 comments Download
M runtime/bin/process_win.cc View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/bin/socket_android.cc View 1 2 2 chunks +10 lines, -5 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/socket_macos.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/socket_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M runtime/bin/test_extension_dllmain_win.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M runtime/bin/utils_android.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/bin/utils_linux.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/bin/utils_macos.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/bin/utils_win.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/platform/floating_point_win.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M runtime/platform/thread_android.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/platform/thread_linux.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/platform/thread_macos.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/platform/thread_win.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/os_android.cc View 1 2 2 chunks +14 lines, -9 lines 0 comments Download
M runtime/vm/os_linux.cc View 1 2 2 chunks +13 lines, -8 lines 0 comments Download
M runtime/vm/os_macos.cc View 1 2 2 chunks +13 lines, -8 lines 0 comments Download
M runtime/vm/os_win.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_android.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_linux.cc View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/virtual_memory_macos.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M runtime/vm/virtual_memory_win.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
samples/sample_extension/sample_extension_dllmain_win.cc View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
7 years, 10 months ago (2013-02-19 23:33:22 UTC) #1
siva
lgtm
7 years, 10 months ago (2013-02-20 00:22:19 UTC) #2
Ivan Posva
7 years, 10 months ago (2013-02-20 21:18:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #4 manually as r18786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698