Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 12282045: Using an ordered set for Element.classes. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Using an ordered set for Element.classes. BUG=6946 Committed: https://code.google.com/p/dart/source/detail?r=18727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -24 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_classes_test.dart View 6 chunks +29 lines, -18 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 10 months ago (2013-02-19 21:09:22 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 10 months ago (2013-02-19 21:23:08 UTC) #2
blois
7 years, 10 months ago (2013-02-19 21:37:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18727 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698