Issue 1228093007: Updates for dart:js fixes after initial --gen-interop

Issue 1228093007: Updates for dart:js fixes after initial --gen-interop (Closed)

Created:
5 years, 5 months ago by terry

Modified:
5 years, 5 months ago

Reviewers:
vsm, Alan Knight

CC:
reviews_dartlang.org, ricow1

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Updates for dart:js fixes after initial --gen-interop TBR=vsm@google.com,alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/5e52d8dc5d48859af0efcd1967f5712fd5c93147

Patch Set 3 : merge #

Total comments: 2

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -3 lines)			Patch
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	2 chunks	+4 lines, -1 line	2 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

terry

Committed patchset #3 (id:40001) manually as 5e52d8dc5d48859af0efcd1967f5712fd5c93147 (presubmit successful).

5 years, 5 months ago (2015-07-16 16:52:56 UTC) #1

Alan Knight

LGTM https://codereview.chromium.org/1228093007/diff/40001/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/1228093007/diff/40001/tools/dom/scripts/systemnative.py#newcode1254 tools/dom/scripts/systemnative.py:1254: self._type_registry if self._dart_use_blink else None, Indentation looks very ...

5 years, 5 months ago (2015-07-16 16:55:52 UTC) #2

terry

5 years, 5 months ago (2015-07-16 17:36:14 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/1228093007/diff/40001/tools/dom/scripts/syste...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/1228093007/diff/40001/tools/dom/scripts/syste...
tools/dom/scripts/systemnative.py:1254: self._type_registry if
self._dart_use_blink else None,
On 2015/07/16 16:55:52, Alan Knight wrote:
> Indentation looks very weird here, but it might be just the tool. And it's
> Python, so if the indentation is too far wrong the code probably wouldn't
work.

Because of the preceding ( it indents after the (


Here's the Google style guide
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation:

       # Aligned with opening delimiter
       foo = long_function_name(var_one, var_two,
                                var_three, var_four)

Expand Messages | Collapse Messages