Warn if pub isn't up-to-date in the SDK repo.

Warn if pub isn't up-to-date in the SDK repo.

This will help avoid issues like #1294 in the future.

R=rnystrom@google.com, rnystrom@gmail.com

Committed: https://github.com/dart-lang/pub/commit/fed52e2f02a76e1c556fc5be54859b0575ed04dc

[Bob Nystrom, 2015-07-13 17:15:35]

rnystrom@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2015-07-13 17:15:35]

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart
File lib/src/command_runner.dart (right):

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart...
lib/src/command_runner.dart:165: var pubRevRegExp = new RegExp(r'^ +"pub_rev":
+"@([^"]+)"', multiLine: true);
Long line.

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart...
lib/src/command_runner.dart:167: if (match == null) return;
Do we want to silently fail?

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart...
lib/src/command_runner.dart:170: var actualRev = git.runSync(["rev-parse",
"HEAD"], workingDir: pubRoot)
What does this do to the test cycle time?

[nweiz, 2015-07-13 20:13:25]

Code review changes

[nweiz, 2015-07-13 20:13:34]

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart
File lib/src/command_runner.dart (right):

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart...
lib/src/command_runner.dart:165: var pubRevRegExp = new RegExp(r'^ +"pub_rev":
+"@([^"]+)"', multiLine: true);
On 2015/07/13 17:15:35, Bob Nystrom wrote:
> Long line.

Done.

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart...
lib/src/command_runner.dart:167: if (match == null) return;
On 2015/07/13 17:15:35, Bob Nystrom wrote:
> Do we want to silently fail?

I don't really want to make this a place where we could break pub for everyone
running from the repo.

https://codereview.chromium.org/1227913009/diff/1/lib/src/command_runner.dart...
lib/src/command_runner.dart:170: var actualRev = git.runSync(["rev-parse",
"HEAD"], workingDir: pubRoot)
On 2015/07/13 17:15:35, Bob Nystrom wrote:
> What does this do to the test cycle time?

I'll run a test. I suspect it won't be that bad; git rev-parse is very fast.

[Bob Nystrom, 2015-07-13 20:14:30]

lgtm

[nweiz, 2015-07-13 21:33:47]

Committed patchset #2 (id:20001) manually as
fed52e2f02a76e1c556fc5be54859b0575ed04dc (presubmit successful).