Issue 1227873004: dart2js cps: Implement compilation of redirecting factory constructors for reflection.

Issue 1227873004: dart2js cps: Implement compilation of redirecting factory constructors for reflection. (Closed)

Created:
5 years, 5 months ago by karlklose

Modified:
5 years, 5 months ago

Reviewers:
asgerf

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Implement compilation of redirecting factory constructors for reflection. Without reflection, redirecting factory constructor invocations are shortcut at the instantiation site. With reflection, code like reflectClass(Foo).newInstance(const Symbol(''), []) can hit a redirecting factory constructor and we need to emit a function that does the redirection and type substitution. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/3fe9309c96b4eda2208463ce3960ea0436810011

Patch Set 1 #

Patch Set 2 : Add test and a comment. #

Patch Set 3 : Add test status for new test. #

Patch Set 4 : Add another comment. #

Total comments: 1

Patch Set 5 : Address comment. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+859 lines, -902 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	1 2 3 4	1 chunk	+36 lines, -0 lines	0 comments	Download
M	pkg/pkg.status	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View		2 chunks	+382 lines, -382 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+16 lines, -17 lines	0 comments	Download
M	tests/compiler/dart2js_native/dart2js_native.status	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/isolate/isolate.status	View		1 chunk	+52 lines, -52 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2 3 4	3 chunks	+60 lines, -59 lines	0 comments	Download
A +	tests/language/redirecting_factory_reflection_test.dart	View	1	1 chunk	+13 lines, -8 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+285 lines, -368 lines	0 comments	Download
M	tests/standalone/standalone.status	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

asgerf

LGTM if the TODO is resolved. https://codereview.chromium.org/1227873004/diff/60001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right): https://codereview.chromium.org/1227873004/diff/60001/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart#newcode277 pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:277: // system implements ...

5 years, 5 months ago (2015-07-09 09:47:54 UTC) #2

karlklose

5 years, 5 months ago (2015-07-09 12:55:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 (id:80001) manually as
3fe9309c96b4eda2208463ce3960ea0436810011 (presubmit successful).

Expand Messages | Collapse Messages