Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1227733002: VM: Load common VM constants from Thread on ARM and MIPS. (Closed)

Created:
5 years, 5 months ago by Florian Schneider
Modified:
5 years, 5 months ago
Reviewers:
koda
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Load common VM constants from Thread on ARM and MIPS. This saves code size and also makes intrinsic code relocatable since the UpdateStoreBuffer-stub is now called indirectly (loaded from THR) instead of embedded as an immediate. Also addressed feedback from previous CL. BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/9bdab8ee2b9a3f52ef7e5e31468ae7553942e9a4

Patch Set 1 #

Total comments: 2

Patch Set 2 : added back assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M runtime/vm/assembler_arm.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/thread.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 5 months ago (2015-07-08 14:16:19 UTC) #2
koda
lgtm https://codereview.chromium.org/1227733002/diff/1/runtime/vm/assembler_mips.cc File runtime/vm/assembler_mips.cc (right): https://codereview.chromium.org/1227733002/diff/1/runtime/vm/assembler_mips.cc#newcode472 runtime/vm/assembler_mips.cc:472: } else if (object.InVMHeap() || !allow_constant_pool()) { Oh, ...
5 years, 5 months ago (2015-07-08 14:50:34 UTC) #3
Florian Schneider
https://codereview.chromium.org/1227733002/diff/1/runtime/vm/assembler_mips.cc File runtime/vm/assembler_mips.cc (right): https://codereview.chromium.org/1227733002/diff/1/runtime/vm/assembler_mips.cc#newcode472 runtime/vm/assembler_mips.cc:472: } else if (object.InVMHeap() || !allow_constant_pool()) { On 2015/07/08 ...
5 years, 5 months ago (2015-07-09 08:50:36 UTC) #4
Florian Schneider
5 years, 5 months ago (2015-07-09 09:12:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9bdab8ee2b9a3f52ef7e5e31468ae7553942e9a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698