Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1227643003: dart2js: Move most of the code_emitter_task code into the program-builder. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Move most of the code_emitter_task code into the program-builder. R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/21b3463d8145adbcead06dbb746eaaac523158f5

Patch Set 1 #

Patch Set 2 : Minor changes and indentation. #

Patch Set 3 : more indentation. #

Patch Set 4 : Upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -512 lines) Patch
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +16 lines, -283 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 13 chunks +26 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 3 chunks +11 lines, -8 lines 0 comments Download
A + pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 2 3 7 chunks +20 lines, -174 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 10 chunks +38 lines, -15 lines 0 comments Download
M pkg/dart2js_incremental/lib/caching_compiler.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/deferred_load_graph_segmentation_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/deferred_not_in_main_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 5 months ago (2015-07-07 15:34:14 UTC) #2
herhut
lgtm
5 years, 5 months ago (2015-07-08 09:00:06 UTC) #3
floitsch
5 years, 5 months ago (2015-07-08 10:53:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
21b3463d8145adbcead06dbb746eaaac523158f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698