Issue 1227543008: dart2js cps: Generate direct field accesses a build-time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1227543008: dart2js cps: Generate direct field accesses a build-time. (Closed)

Created:
5 years, 5 months ago by asgerf

Modified:
5 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Generate direct field accesses a build-time. The world will refuse to emit getters and setters for field it thinks will be accessed directly. Rewriting getter/setter calls to field accesses must happen at build-time so we do not rely on an optimization for correctness. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/11b2ae130731b19ea8c32765d39dc58867d8cdac

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -7 lines)			Patch
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View	3 chunks	+27 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js_native/dart2js_native.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

5 years, 5 months ago (2015-07-07 14:17:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
11b2ae130731b19ea8c32765d39dc58867d8cdac (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages