Fixing Geolocation on Firefox

Fixing Geolocation on Firefox

For position, Firefox is returning an object which doesn't map nicely, so added a wrapper for that.

Also cleaned up the APIs to make them more dart-friendly.

BUG=7547
Committed: https://code.google.com/p/dart/source/detail?r=18723

[Emily Fortuna, 2013-02-19 19:53:00]

lgtm, with one comment fix. 

+Martin. I'm adding some people on the testing team so they can be aware that we
have this test that is basically manual right now (requires interaction).
Perhaps our non-selenium framework can have a mechanism to deal with this? I can
share what I know about RTC testing happening elsewhere.

https://codereview.chromium.org/12274002/diff/3008/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Geolocation.darttemplate (right):

https://codereview.chromium.org/12274002/diff/3008/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Geolocation.darttemplate:90: * Wrapper for
FireFox- it returns an object which we cannot map correctly.
nit: "Firefox"

[blois, 2013-02-19 21:14:29]

On 2013/02/19 19:53:00, Emily Fortuna wrote:
> lgtm, with one comment fix. 
> 
> +Martin. I'm adding some people on the testing team so they can be aware that
we
> have this test that is basically manual right now (requires interaction).
> Perhaps our non-selenium framework can have a mechanism to deal with this? I
can
> share what I know about RTC testing happening elsewhere.
> 
>
https://codereview.chromium.org/12274002/diff/3008/tools/dom/templates/html/i...
> File tools/dom/templates/html/impl/impl_Geolocation.darttemplate (right):
> 
>
https://codereview.chromium.org/12274002/diff/3008/tools/dom/templates/html/i...
> tools/dom/templates/html/impl/impl_Geolocation.darttemplate:90: * Wrapper for
> FireFox- it returns an object which we cannot map correctly.
> nit: "Firefox"

For explanation of the tests- the Geolocation and MediaStream APIs prompt for
user permission before functioning. The interactive_test is just one that you
need to run manually, and click 'allow' to all the permission dialogs.

[blois, 2013-02-19 21:18:45]

Committed patchset #2 manually as r18723 (presubmit successful).

[ricow1, 2013-08-22 11:26:13]

https://codereview.chromium.org/12274002/diff/3008/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12274002/diff/3008/tests/html/html.status#new...
tests/html/html.status:10: interactive_test: Skip # Must be run manually.
If this needs to be run manually how about just not calling this _test?

[blois, 2013-08-22 16:14:56]

https://codereview.chromium.org/12274002/diff/3008/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/12274002/diff/3008/tests/html/html.status#new...
tests/html/html.status:10: interactive_test: Skip # Must be run manually.
On 2013/08/22 11:26:13, ricow1 wrote:
> If this needs to be run manually how about just not calling this _test?

If it's not _test, is there an easy way to generate the test HTML and dart2js
files for it?

[ricow1, 2013-08-22 16:16:11]

On 2013/08/22 16:14:56, blois wrote:
> https://codereview.chromium.org/12274002/diff/3008/tests/html/html.status
> File tests/html/html.status (right):
> 
>
https://codereview.chromium.org/12274002/diff/3008/tests/html/html.status#new...
> tests/html/html.status:10: interactive_test: Skip # Must be run manually.
> On 2013/08/22 11:26:13, ricow1 wrote:
> > If this needs to be run manually how about just not calling this _test?
> 
> If it's not _test, is there an easy way to generate the test HTML and dart2js
> files for it?

no, that was not really what I assumed when I saw it it said manually - so
nevermind :-)