Issue 1227123004: Fix prefix errors with --noopt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1227123004: Fix prefix errors with --noopt (Closed)

Created:
5 years, 5 months ago by srdjan

Modified:
5 years, 5 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix prefix errors with --noopt BUG= Committed: https://github.com/dart-lang/sdk/commit/04fa456a8800ade9626c64ed5a15f6d3d9bbef7e

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

Committed patchset #1 (id:1) manually as 04fa456a8800ade9626c64ed5a15f6d3d9bbef7e (presubmit successful).

5 years, 5 months ago (2015-07-10 20:31:14 UTC) #4

hausner

5 years, 5 months ago (2015-07-10 21:47:49 UTC) #5

Message was sent while issue was closed.

LGTM w/comment.

https://codereview.chromium.org/1227123004/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1227123004/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:12055: if ((!FLAG_load_deferred_eagerly ||
!allow_deferred_type) &&
This is becoming kind of unreadable.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages