Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12271004: Fixing node.nodes.addAll to accept node lists. (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing node.nodes.addAll to accept node lists. Had two options- change the iterators or do a defensive copy. I believe this is a fairly performance-critical area, so tried to optimize for that. BUG=6684 Committed: https://code.google.com/p/dart/source/detail?r=18545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M tests/html/node_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 10 months ago (2013-02-14 21:27:57 UTC) #1
Jennifer Messerly
7 years, 10 months ago (2013-02-14 21:32:04 UTC) #2 
lgtm!

Powered by Google App Engine
This is Rietveld 408576698