Issue 1226823003: Improve propagation in binary expressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226823003: Improve propagation in binary expressions (Closed)

Created:
5 years, 5 months ago by Brian Wilkerson

Modified:
5 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Improve propagation in binary expressions R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/27f600058e5a0c803fa3ba4bfb40b949171d268e

Patch Set 1 #

Total comments: 1

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -18 lines)			Patch
M	pkg/analysis_server/test/services/refactoring/extract_method_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	6 chunks	+27 lines, -17 lines	1 comment	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	3 chunks	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

LGTM https://codereview.chromium.org/1226823003/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right): https://codereview.chromium.org/1226823003/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart#newcode1391 pkg/analyzer/lib/src/generated/static_type_analyzer.dart:1391: return _dynamicType; AFAIK Expression.bestType already returns DynamicTypeImpl.instance instead ...

5 years, 5 months ago (2015-07-07 22:14:58 UTC) #3

Brian Wilkerson

5 years, 5 months ago (2015-07-08 15:02:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
27f600058e5a0c803fa3ba4bfb40b949171d268e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages