Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1226323002: Remove 'async-await' usage from the dart2js compiler. (Closed)

Created:
5 years, 5 months ago by Anders Johnsen
Modified:
5 years, 5 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove 'async-await' usage from the dart2js compiler. BUG= R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/7054159b904fe35ac5b5a30426729821085aea35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -25 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +31 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Anders Johnsen
5 years, 5 months ago (2015-07-09 07:11:23 UTC) #2
floitsch
LGTM.
5 years, 5 months ago (2015-07-09 08:54:18 UTC) #3
Anders Johnsen
Committed patchset #1 (id:1) manually as 7054159b904fe35ac5b5a30426729821085aea35 (presubmit successful).
5 years, 5 months ago (2015-07-09 11:41:12 UTC) #4
Siggi Cherem (dart-lang)
what's preventing us from using async/await?
5 years, 5 months ago (2015-07-09 20:03:13 UTC) #6
floitsch
On 2015/07/09 20:03:13, Siggi Cherem (dart-lang) wrote: > what's preventing us from using async/await? Fletch ...
5 years, 5 months ago (2015-07-10 09:37:54 UTC) #7
Siggi Cherem (dart-lang)
On 2015/07/10 09:37:54, floitsch wrote: > On 2015/07/09 20:03:13, Siggi Cherem (dart-lang) wrote: > > ...
5 years, 5 months ago (2015-07-10 17:21:58 UTC) #8
floitsch
5 years, 5 months ago (2015-07-10 17:28:37 UTC) #9
Message was sent while issue was closed.
On 2015/07/10 17:21:58, Siggi Cherem (dart-lang) wrote:
> On 2015/07/10 09:37:54, floitsch wrote:
> > On 2015/07/09 20:03:13, Siggi Cherem (dart-lang) wrote:
> > > what's preventing us from using async/await?
> > 
> > Fletch doesn't support it yet.
> 
> Are there other features like this that it doesn't support? I was planning on
> start using null-aware operators any time now.
Go ahead. If there are features that are missing in Fletch, then they should be
added to Fletch.
Async/await is a completely different story, because it is so difficult to add
to a VM (just look at how long it took the VM and dart2js to add it).
Since dart2js only uses async/await in extremely few cases, it doesn't make
sense to hold Fletch back just for that.

> 
> I'm surprised fletch is adding constraints on what we can do in dart2js
though.
> I know fletch uses dart2js to build bytecodes, but I thought it would simply
run
> dart2js on the vm, not directly in fletch itself. Is there an actual need to
run
> the compiler within fletch?
Fletch is now able to self-host. That's a very nice result.

> 
> Honestly, I really would like us to be able to use the dart language features
> freely in dart2js. So I'd like to chat about how we get there quickly.
If I had the impression that this would impact the work on dart2js I wouldn't
have LGTMed the CL.

Powered by Google App Engine
This is Rietveld 408576698