Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 12263046: Fixing DOM's EventStream.isBroadcast (Closed)

Created:
7 years, 10 months ago by blois
Modified:
7 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixing DOM's EventStream.isBroadcast BUG=8457 Committed: https://code.google.com/p/dart/source/detail?r=18541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/streams_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
7 years, 10 months ago (2013-02-14 19:58:13 UTC) #1
Emily Fortuna
7 years, 10 months ago (2013-02-14 20:00:35 UTC) #2
lgtm. I remember looking at that code yesterday and thinking we were missing
that method. :-)

Powered by Google App Engine
This is Rietveld 408576698