Issue 12263017: Add flag to block optimizations of large implicit getters. Implicit getters have a 0 size in tokens…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12263017: Add flag to block optimizations of large implicit getters. Implicit getters have a 0 size in tokens… (Closed)

Created:
7 years, 10 months ago by srdjan

Modified:
7 years, 10 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add flag to block optimizations of large implicit getters. Implicit getters have a 0 size in tokens, therefore also check the size of unoptimized code to decide if a function is optimizable. Print more data with --trace-compiler. Committed: https://code.google.com/p/dart/source/detail?r=18485

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1399 lines, -9 lines)			Patch
M	runtime/vm/compiler.cc	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3 4	2 chunks	+18 lines, -6 lines	0 comments	Download
A	tests/language/large_implicit_getter_test.dart	View	1 2 3	1 chunk	+1376 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment regarding size in words and not bytes. https://codereview.chromium.org/12263017/diff/6001/runtime/vm/object.cc File runtime/vm/object.cc (right): ...

7 years, 10 months ago (2013-02-13 21:31:16 UTC) #2

srdjan

7 years, 10 months ago (2013-02-13 21:37:10 UTC) #3

Also added a test file.

https://codereview.chromium.org/12263017/diff/6001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/12263017/diff/6001/runtime/vm/object.cc#newco...
runtime/vm/object.cc:48: "Huge method cutoff in unoptimized code size: disables
optimization.");
On 2013/02/13 21:31:17, siva wrote:
> I think the code cut of size should be in words so that we get an appropriate
> number for 64 bit architectures too.

Done.

Expand Messages | Collapse Messages