Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 12262030: Stop using deprecated charCodeAt in Intl (Closed)

Created:
7 years, 10 months ago by Alan Knight
Modified:
7 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Stop using deprecated charCodeAt in Intl Committed: https://code.google.com/p/dart/source/detail?r=18526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M pkg/intl/lib/bidi_utils.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/intl/lib/number_format.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Alan Knight
Since the function in Bidi that used these wasn't called anywhere and was private, I ...
7 years, 10 months ago (2013-02-13 23:54:38 UTC) #1
Emily Fortuna
7 years, 10 months ago (2013-02-14 00:10:55 UTC) #2
lgtm!

Powered by Google App Engine
This is Rietveld 408576698