Issue 1226133003: Fix several problems with offline mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1226133003: Fix several problems with offline mode. (Closed)

Created:
5 years, 5 months ago by nweiz

Modified:
5 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/pub.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix several problems with offline mode. * Some HTTP requests were still being made. These are now avoided, and the tests have been modified to assert that no HTTP requests are made at all. * When a specific package version was in a package's lockfile *and* available on the server but wasn't in the user's cache, pub would crash when run in offline mode. Closes #1293 Print a nice error for missing offline packages. Previously, this would print an unhelpful message along with "this is an unexpected error". Closes #1293 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/e47378e67dc1ce1774d611768e04429dddabd7ec

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -12 lines)			Patch
M	lib/src/source/hosted.dart	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	test/hosted/offline_test.dart	View	4 chunks	+43 lines, -5 lines	0 comments	Download
M	test/test_pub.dart	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Very nice. LGTM!

Expand Messages | Collapse Messages