Issue 12261054: Mark standalone/io/socket_stream_close_test as flaky on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12261054: Mark standalone/io/socket_stream_close_test as flaky on windows. (Closed)

Created:
7 years, 10 months ago by ricow1

Modified:
7 years, 10 months ago

Reviewers:
Bill Hesse, ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark standalone/io/socket_stream_close_test as flaky on windows. See http://dartbug.com/8556 Committed: https://code.google.com/p/dart/source/detail?r=18567

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/standalone/standalone.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, thank you! https://codereview.chromium.org/12261054/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/12261054/diff/1/tests/standalone/standalone.status#newcode48 tests/standalone/standalone.status:48: io//socket_stream_close_test: Fail, Pass # Issue 8556. ...

7 years, 10 months ago (2013-02-15 09:23:04 UTC) #2

ricow1

7 years, 10 months ago (2013-02-15 09:24:55 UTC) #4

https://codereview.chromium.org/12261054/diff/1/tests/standalone/standalone.s...
File tests/standalone/standalone.status (right):

https://codereview.chromium.org/12261054/diff/1/tests/standalone/standalone.s...
tests/standalone/standalone.status:48: io//socket_stream_close_test: Fail, Pass
# Issue 8556.
On 2013/02/15 09:23:04, ahe wrote:
> Extra /

Done.

Expand Messages | Collapse Messages

Issue 12261054: Mark standalone/io/socket_stream_close_test as flaky on windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages