Issue 12261009: Added implementation of String.codeUnits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12261009: Added implementation of String.codeUnits. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 10 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added implementation of String.codeUnits. Based on ListIterable implementation that should be reusable for a lot of our existing length/indexing-based iterables too. Committed: https://code.google.com/p/dart/source/detail?r=18506

Patch Set 1 #

Patch Set 2 : Fix typos #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+370 lines, -7 lines)			Patch
M	runtime/lib/string_base.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_collection_dev/iterable.dart	View	1	1 chunk	+311 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/core/string.dart	View		2 chunks	+13 lines, -1 line	0 comments	Download
A	tests/corelib/string_codeunits_test.dart	View		1 chunk	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages