Issue 12261006: Share addTypeVariableReference between factory calls and is-checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12261006: Share addTypeVariableReference between factory calls and is-checks. (Closed)

Created:
7 years, 10 months ago by karlklose

Modified:
7 years, 10 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Share addTypeVariableReference between factory calls and is-checks. Committed: https://code.google.com/p/dart/source/detail?r=18507

Patch Set 1 #

Patch Set 2 : Add a test. #

Patch Set 3 : Ad another test. #

Total comments: 1

Patch Set 4 : Rename the second test. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -72 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		4 chunks	+48 lines, -60 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/typevariable_factory_test.dart	View	1	1 chunk	+8 lines, -12 lines	0 comments	Download
A	tests/compiler/dart2js_extra/typevariable_substitution_test.dart	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! As discussed, please add a test case that failed before this refactoring.

7 years, 10 months ago (2013-02-13 14:05:23 UTC) #2

ngeoffray

7 years, 10 months ago (2013-02-13 14:27:49 UTC) #4

LGTM

https://codereview.chromium.org/12261006/diff/7001/tests/compiler/dart2js_ext...
File tests/compiler/dart2js_extra/typevariable_factory2_test.dart (right):

https://codereview.chromium.org/12261006/diff/7001/tests/compiler/dart2js_ext...
tests/compiler/dart2js_extra/typevariable_factory2_test.dart:1: // Copyright (c)
2013, the Dart project authors.  Please see the AUTHORS file
Please rename this test.

Expand Messages | Collapse Messages