Issue 12261005: Simplify the FunctionSet implementation and remove a slightly broken optimization from SelectorMap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12261005: Simplify the FunctionSet implementation and remove a slightly broken optimization from SelectorMap. (Closed)

Created:
7 years, 10 months ago by kasperl

Modified:
7 years, 10 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Simplify the FunctionSet implementation and remove a slightly broken optimization from SelectorMap. This saves around 70 ms when compiling swarm, so it's not a big deal performance-wise but the code is much simpler. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18444

Patch Set 1 #

Total comments: 2

Patch Set 2 : Avoid is checks. #

Patch Set 3 : Add comment. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -178 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/universe/function_set.dart	View	1 2	2 chunks	+95 lines, -94 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/partial_type_tree.dart	View		1 chunk	+2 lines, -46 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/selector_map.dart	View		4 chunks	+30 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

7 years, 10 months ago (2013-02-13 14:14:09 UTC) #2

LGTM

https://codereview.chromium.org/12261005/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/universe/function_set.dart
(right):

https://codereview.chromium.org/12261005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/universe/function_set.dart:37: :
false;
Fits in one line?

https://codereview.chromium.org/12261005/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/universe/function_set.dart:81: // set
we try to avoid clearing the cache unless we have to. For
I had a hard time understanding this sentence. Maybe rephrase to: "we avoid
clearing the cache when the element is already in the collection".

Expand Messages | Collapse Messages