Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1226083002: Fix several Windows issues. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix several Windows issues. * forward_signal_posix_test needed to be marked as incompatible with Windows. * Deleting the sandbox directory would sometimes fail due to locking issues, and this failure would obscure underlying issues. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/9925ee73cb34d49359211b7b7c69faf0d927e900

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove debug print #

Patch Set 3 : Code review changes #

Patch Set 4 : Code review changes #

Patch Set 5 : Remove CR LF fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M test/run/forwards_signal_posix_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M test/test_pub.dart View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
5 years, 5 months ago (2015-07-08 20:54:33 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/1226083002/diff/1/lib/src/cr_lf_remover.dart File lib/src/cr_lf_remover.dart (right): https://codereview.chromium.org/1226083002/diff/1/lib/src/cr_lf_remover.dart#newcode35 lib/src/cr_lf_remover.dart:35: if (sink is! ByteConversionSink) sink = new ByteConversionSink.from(sink); ...
5 years, 5 months ago (2015-07-08 22:12:16 UTC) #2
nweiz
Code review changes
5 years, 5 months ago (2015-07-09 00:29:53 UTC) #3
nweiz
Code review changes
5 years, 5 months ago (2015-07-09 00:30:03 UTC) #4
nweiz
https://codereview.chromium.org/1226083002/diff/1/lib/src/cr_lf_remover.dart File lib/src/cr_lf_remover.dart (right): https://codereview.chromium.org/1226083002/diff/1/lib/src/cr_lf_remover.dart#newcode35 lib/src/cr_lf_remover.dart:35: if (sink is! ByteConversionSink) sink = new ByteConversionSink.from(sink); On ...
5 years, 5 months ago (2015-07-09 00:30:14 UTC) #5
nweiz
5 years, 5 months ago (2015-07-10 21:58:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
9925ee73cb34d49359211b7b7c69faf0d927e900 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698