Issue 12260009: Update language_dart2js.status to expect failure on branch_canonicalization_test due to differences…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12260009: Update language_dart2js.status to expect failure on branch_canonicalization_test due to differences… (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update language_dart2js.status to expect failure on branch_canonicalization_test due to differences in integer semantics. Fix style issues in the test itself. R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=18450

Patch Set 1 #

Total comments: 1

Patch Set 2 : address Peter's comment #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	tests/language/branch_canonicalization_test.dart	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	tests/language/language_dart2js.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

7 years, 10 months ago (2013-02-13 15:05:22 UTC) #2

Almost LGTM, but be sure to move the status file line before you submit.

https://codereview.chromium.org/12260009/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/12260009/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:30: branch_canonicalization_test: Fail #
dartbug.com/638
This test is not failing on dart2dart, so I suggest you move this to line 94.

Expand Messages | Collapse Messages