Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 12259026: Added "dartc_bot" target in dart.gyp (Closed)

Created:
7 years, 10 months ago by kustermann
Modified:
7 years, 10 months ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added "dartc_bot" target in dart.gyp Currently the dartc bots only use 'tools/build.py create_sdk'. But since dartc analzes tests that use package imports this causes issues. Although we pass in the package root (i.e. 'dart_analzer --package-root=out/Mode/packages/ ... '), we don't create the package links on the bot (in the create_sdk step). This CL creates a new 'dartc_bot' target which depends on the 'packages' target in addition to 'create_sdk'. Another CL will change the buildbot to use the new target. Committed: https://code.google.com/p/dart/source/detail?r=18523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M dart.gyp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 10 months ago (2013-02-14 17:16:56 UTC) #1
ricow1
LGTM
7 years, 10 months ago (2013-02-14 17:22:29 UTC) #2
ahe
7 years, 10 months ago (2013-02-14 19:03:41 UTC) #3
Message was sent while issue was closed.
Actually, dartc should build everything. This is something we agreed upon a long
time ago because it otherwise finishes so quickly.

Powered by Google App Engine
This is Rietveld 408576698