Issue 12258022: Fixing IndexedDB Dartium Checked Mode tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12258022: Fixing IndexedDB Dartium Checked Mode tests (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing IndexedDB Dartium Checked Mode tests A type check for the Stream<Cursor> was failing on Dartium. Basically the helper method is intended to work for both Cursor and CursorWithValue, but it was creating a StreamController<Cursor>. Just removed the type so it works acceptably with both. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18486

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages