Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 12258018: Fix benchmark smoke test as well with change. (Closed)

Created:
7 years, 10 months ago by Emily Fortuna
Modified:
7 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix benchmark smoke test as well with change. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M tests/benchmark_smoke/benchmark_base.dart View 6 chunks +12 lines, -11 lines 0 comments Download
M tests/benchmark_smoke/benchmark_lib.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/benchmark_smoke/benchmark_smoke_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Emily Fortuna
TBR Missed these tests.
7 years, 10 months ago (2013-02-13 20:50:01 UTC) #1
blois
7 years, 10 months ago (2013-02-13 20:52:34 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698