Issue 122573002: Compute range for Smi multiplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 122573002: Compute range for Smi multiplication. (Closed)

Created:
6 years, 11 months ago by srdjan

Modified:
6 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Compute range for Smi multiplication. Especially useful when working on canvas (Uint8ClampedList). R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=31504

Patch Set 7 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	runtime/vm/intermediate_language.cc	View	1 2 3 4 5 6	2 chunks	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

lgtm https://codereview.chromium.org/122573002/diff/170001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/122573002/diff/170001/runtime/vm/intermediate_language.cc#newcode2623 runtime/vm/intermediate_language.cc:2623: const int64_t a = Utils::Abs(Range::ConstantMin(range).value()); Maybe rename a/b ...

6 years, 11 months ago (2014-01-06 19:11:43 UTC) #2

srdjan

https://codereview.chromium.org/122573002/diff/170001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/122573002/diff/170001/runtime/vm/intermediate_language.cc#newcode2623 runtime/vm/intermediate_language.cc:2623: const int64_t a = Utils::Abs(Range::ConstantMin(range).value()); On 2014/01/06 19:11:43, Florian ...

6 years, 11 months ago (2014-01-06 20:39:09 UTC) #3

srdjan

6 years, 11 months ago (2014-01-06 21:22:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #7 manually as r31504 (presubmit successful).

Expand Messages | Collapse Messages

Issue 122573002: Compute range for Smi multiplication. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Messages