Issue 12255055: Make Comparable generic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12255055: Make Comparable generic. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 10 months ago

Reviewers:
floitsch, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make Comparable generic. It's now allowed to write "class X implements Comparable<X>" to make X comparable only to X's. The argument type of Comparable<T>.compareTo is now T. Committed: https://code.google.com/p/dart/source/detail?r=18655

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	pkg/fixnum/lib/src/int32.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/lib/logging.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/serialization/lib/src/basic_rule.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/comparable.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/core/date_time.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/core/num.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/css/source.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	utils/pub/package.dart	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	utils/template/source.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

Please run at least a few tests before submitting changes :-)

7 years, 10 months ago (2013-02-19 08:08:19 UTC) #3

Lasse Reichstein Nielsen

7 years, 10 months ago (2013-02-19 09:40:36 UTC) #4

Message was sent while issue was closed.

I ran ALL the tests in checked mode! ... but only on the VM in release mode :(

Expand Messages | Collapse Messages